Looks reasonable. Was this found by static code analysis?
On Fri, Jan 20, 2012 at 7:04 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
> fs/cifs/connect.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 986709a..aa687c8 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2125,7 +2125,7 @@ cifs_set_cifscreds(struct smb_vol *vol, struct cifs_ses *ses)
> down_read(&key->sem);
> upayload = key->payload.data;
> if (IS_ERR_OR_NULL(upayload)) {
> - rc = PTR_ERR(key);
> + rc = upayload ? PTR_ERR(upayload) : -EINVAL;
> goto out_key_put;
> }
>
> --
> 1.7.7.5
>
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
