On Fri, 20 Jan 2012 11:21:32 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> Hi Jeff,
>
> The patch 8a8798a5ff90: "cifs: fetch credentials out of keyring for
> non-krb5 auth multiuser mounts" from Jan 17, 2012, has a problem here:
>
> + upayload = key->payload.data;
> + if (IS_ERR_OR_NULL(upayload)) {
> + rc = PTR_ERR(key);
> ^^^
> "key" is a valid pointer not an ERR_PTR. Also "upayload" can be NULL
> and PTR_ERR(NULL) is success.
>
> + goto out_key_put;
> + }
>
> regards,
> dan carpenter
>
Doh! Good catch. Steve has already queued this patch for inclusion, but
I'll spin up a patch to fix it.
Thanks,
--
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
