On Fri, 30 Dec 2011 01:50:24 +0400 Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote: > Hi all! > > I will be on holidays for about a week or a little more (will check > email box). I pushed the last status of SMB2 patches into smb2-dev > branch: > http://git.altlinux.org/people/piastry/public/?p=cifs-2.6.git;a=shortlog;h=refs/heads/smb2-dev > > It's not the final variant - that's why I didn't posted them to the > list. There is still some work to be done - I want to drop the first > patch "CIFS: Add structure definitions for SMB2 PDUs" and add each PDU > structure with it's first usage. > > So, can you look and comment if possible on the approach and design of > this version of the patch series, please? > Looks ok overall, but I haven't looked in depth. Once you post the patches I'll have more specific comments. Again, it's difficult to review unposted patches since I can't easily comment on them inline. In general I urge you to get rid of any patches that add code or struct members that are not actually used by that patch. Sometimes that's unavoidable, but in those cases, the patch description should explain why and what the new things are for. The first patch is mostly OK actually. Most of those structs are protocol definitions, so it's pretty clear what they're for. Since they describe the what goes over the wire, there's little to review there. That said, it wouldn't hurt to add them as you need them since that will make the patch series "flow" more nicely. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
