Most KDCs are case-sensitive (the notable exception being AD), but DNS
is case-insensitive. To prevent admins from having to put in all
possible case combinations of a principal, lowercase the hostname prior
to trying to get a principal.
Signed-off-by: Jeff Layton <jlayton@xxxxxxxxx>
---
cifs.upcall.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/cifs.upcall.c b/cifs.upcall.c
index 615c827..2fe2dba 100644
--- a/cifs.upcall.c
+++ b/cifs.upcall.c
@@ -45,6 +45,7 @@
#include <time.h>
#include <netdb.h>
#include <arpa/inet.h>
+#include <ctype.h>
#include "util.h"
#include "replace.h"
@@ -747,6 +748,16 @@ static int ip_to_fqdn(const char *addrstr, char *host, size_t hostlen)
return 0;
}
+/* walk a string and lowercase it in-place */
+static void
+lowercase_string(char *c)
+{
+ while(*c) {
+ *c = tolower(*c);
+ ++c;
+ }
+}
+
static void usage(void)
{
fprintf(stderr, "Usage: %s [-t] [-v] [-l] key_serial\n", prog);
@@ -894,6 +905,7 @@ retry_new_hostname:
* try getting a cifs/ principal first and then fall back to
* getting a host/ principal if that doesn't work.
*/
+ lowercase_string(host);
strlcpy(princ, "cifs/", sizeof(princ));
strlcpy(princ + 5, host, sizeof(princ) - 5);
rc = handle_krb5_mech(oid, princ, &secblob, &sess_key, ccname);
--
1.7.6.4
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
