Re: [PATCH] cifs: lower default wsize when unix extensions are not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 9 Nov 2011 15:14:30 -0600
Steve French <smfrench@xxxxxxxxx> wrote:

> Part of the issue is whether we view this as a server "bug" or not.
> Reading the documentation it looks to me like a server bug if
> it doesn't handle writes up to almost 128K when the flag is on
> (even though Windows client doesn't us send requests for over 64K,
> or at least rarely sends over 64K).  I don't remember seeing problems
> with this to any Windows servers, but clearly if more than one
> major server (NetApp or EMC etc., not just Solaris) had this problem,
> your argument makes sense.  If this is just a bug in a single server
> implementation, then detecting that and working around it probably
> makes more sense than punishing NetApp, EMC and Windows
> for another vendors bug.  Do we have data on problems to
> any other servers with large writes?
> 

I'm not sure and that's a problem. For every user like Nick that takes
the time to report these sorts of issues, we may have dozens that
just give up and walk away when they hit them.

I don't see anywhere in the spec that mentions the (128k - 1) limit on
writes. The description of the CAP_LARGE_WRITE_ANDX flag just says that
if it's set then you can exceed the MaxBufferSize on a WRITE_ANDX.

What it doesn't say (at least not anywhere that I could find) is how
much larger it's allowed to be. Clearly (128k - 1) is a practical limit
since you're not supposed to exceed the RFC1002 size, but it's not a
clear-cut bug if the server doesn't allow up to that limit.

Again, I think we need to be very conservative with the defaults. We
already set the rsize to the Windows default. We should do the same
with the wsize to ensure the default settings just work, regardless of
the server.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux