On Thu, 3 Nov 2011 07:13:54 -0700 Tejun Heo <tj@xxxxxxxxxx> wrote: > Hello, > > On Thu, Nov 03, 2011 at 06:42:15AM -0400, Jeff Layton wrote: > > I'm not sure we really need this macro anymore since this is much > > simpler. I could just move cifs back to using wait_event_killable and > > simply wrap it in freezer_do_not_count/freezer_count (with some > > comments to explain why we're doing that). > > > > In any event, I plan to test this scheme out today and will let you > > know whether it works... > > I think it would be better to put this in a macro as the > implementation is likely to change in future and I really don't want > to see FREEZER_SKIP scattered around the tree. > Ok, note though that I also need to do a similar set of changes to the nfs and sunrpc code [1]. Those call sites do not use wait_event_* macros though. So I'll either need to add a separate set of functions/macros to handle those, or sprinkle freezer_do_not_count/freezer_count around the code there... [1] Here are the older patches that depended on the change to fake_signal_wake_up. I'll need to convert these to use the new scheme once you guys settle on what it should be: https://git.samba.org/jlayton/?p=jlayton/linux.git;a=commitdiff;h=0f85cbb747a0f9f8a582ae9bf642e094168001be https://git.samba.org/jlayton/?p=jlayton/linux.git;a=commitdiff;h=084535708bcb33dd2448e73be5a0f4cac69bea92 -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
