Shirish,
Would you fix the sparse warning from your patch?
Remember to run sparse with make ie add
C=1 CF="-D__CHECK_ENDIAN__"
to your make (see below)
CHECK fs/cifs/smbencrypt.c
fs/cifs/smbencrypt.c:216:37: warning: incorrect type in argument 1
(different base types)
fs/cifs/smbencrypt.c:216:37: expected restricted __le16 [usertype] *<noident>
fs/cifs/smbencrypt.c:216:37: got unsigned short *<noident>
On Thu, Oct 20, 2011 at 1:21 PM, <shirishpargaonkar@xxxxxxxxx> wrote:
> From: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx>
>
>
> Re-posting a patch originally posted by Oskar Liljeblad after
> rebasing on 3.2.
>
>
> Modify cifs to assume that the supplied password is encoded according
> to iocharset. Before this patch passwords would be treated as
> raw 8-bit data, which made authentication with Unicode passwords impossible
> (at least passwords with characters > 0xFF).
>
> The previous code would as a side effect accept passwords encoded with
> ISO 8859-1, since Unicode < 0x100 basically is ISO 8859-1. Software which
> relies on that will no longer support password chars > 0x7F unless it also
> uses iocharset=iso8859-1. (mount.cifs does not care about the encoding so
> it will work as expected.)
>
> Signed-off-by: Oskar Liljeblad <oskar@xxxxxxxxxxx>
> Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx>
> Tested-by: A <nimbus1_03087@xxxxxxxxx>
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
