Re: Remove noisy log message in smb2 readdir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/10/28 Steve French <smfrench@xxxxxxxxx>:
> Pavel,
> smb2 readdir is noisy (logging every time).  Do you want to merge
> this in to an existing patch, or add it as distinct patch.
>
> Also readdir logs the "expected" return codes (status code) on
> medium to large directories since smb2_sendrcv2 is being called for
> smb2 search with the "LOG_ERROR" flag.
>
> diff --git a/fs/cifs/smb2readdir.c b/fs/cifs/smb2readdir.c
> index 7d80e8b..b4c32d5 100644
> --- a/fs/cifs/smb2readdir.c
> +++ b/fs/cifs/smb2readdir.c
> @@ -412,7 +412,6 @@ static int initiate_smb2_search(const int xid,
> struct file *file)
>        if (full_path == NULL)
>                return -ENOMEM;
>
> -       cifs_dump_mem("about to search on name: ", full_path, 4);
>        rc = SMB2_open(xid, tcon, full_path, &persistent_fid, &volatile_fid,
>                        FILE_READ_ATTRIBUTES | FILE_READ_DATA, FILE_OPEN, 0, 0,
>                        &oplock);
>
> --
> Thanks,
>
> Steve
>

Thanks! I prefer it to be included in my readdir patch - will do it
soon and reposted.

-- 
Best regards,
Pavel Shilovsky.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux