Re: [v3 PATCH 0/6] Implement byte-range lock caching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/10/21 Jeff Layton <jlayton@xxxxxxxxxx>:
> On Fri,  7 Oct 2011 23:34:13 +0400
> Pavel Shilovsky <piastry@xxxxxxxxxxx> wrote:
>
>> This patchset is going to simplify brlocking code and add the caching support for exclusive oplock cases. I splitted it into several independent parts - so, each can be applied separately once it's reviewed.
>>
>> This version of the patchset includes some code style improvements in patch #3.
>>
>> Any comments and testing are welcome!
>>
>> Pavel Shilovsky (6):
>>   CIFS: Simplify byte range locking code
>>   CIFS: Move byte range lock list from fd to inode
>>   CIFS: Implement caching mechanism for mandatory brlocks
>>   CIFS: Implement caching mechanism for posix brlocks
>>   CIFS: Send as many mandatory unlock ranges at once as possible
>>   CIFS: Make cifs_push_locks send as many locks at once as possible
>>
>>  fs/cifs/cifsfs.c    |    3 +-
>>  fs/cifs/cifsglob.h  |   10 +-
>>  fs/cifs/cifsproto.h |    9 +-
>>  fs/cifs/cifssmb.c   |   52 +++-
>>  fs/cifs/file.c      |  767 ++++++++++++++++++++++++++++++++++++++++-----------
>>  5 files changed, 661 insertions(+), 180 deletions(-)
>>
>
> I decided to test this out today. With posix extensions enabled, it
> works fine. When I test with posix extensions disabled though,
> connectathon lock test 7 is hanging after step 7.2.
>
> The regression is fortunately in the portion that hasn't been merged
> yet. Pavel, let me know if you need info on how to test that. I don't
> think we can merge the rest of these until that regression is fixed.
>


Thanks for testing this! The regression is caused by patch #3. It's
big enough but it is the one logical change and should be split, I
think. I caught the bug, solved it and now I am giving it more
testing.

-- 
Best regards,
Pavel Shilovsky.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux