I like Pavel's lock cleanup (1st patch of series) so far, am continuing to review it, but I also noticed a few things that we need to do in the future. This line of code: if (flock->fl_flags & FL_LEASE) cFYI(1, "Lease on file - not implemented yet"); reminded me that we should check if we need to implement this (in cifs we can return yes if we have a lease already (oplock), but in smb2.1 and later we can request a lease or an upgrade to an existing one, on the fly). -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html