On Tue, Oct 11, 2011 at 10:21 AM, Steve French <smfrench@xxxxxxxxx> wrote: >>> I don't mind adding a module parm to change the default but it seems >>> odd, and removing the ability to temporarily turn off oplock seems to >>> make things worse not better. But I am not convinced of a good use >>> case for disabling oplocks on module load (rather than the more >>> granular "forcedirectio" on mount, or the temporary ie at runtime via >>> /proc). If oplock/caching on the client were broken, then we would >>> fix the bug rather than ask users to load with oplock off, if oplock >>> were broken on a server, we would not want to disable it for mounts to >>> all servers (as would a module parm) but just to workaround the broken >>> server. >>> >> >> This doesn't prevent you from changing this setting after the module is >> loaded. It just moves the control to a more standard location >> (/sys/module/cifs/parameters). > > If "echo 1 > /sys/module/cifs/parameters/oplock_enabled" would work at runtime, I meant the reverse (obviously oplock is enabled by default) "echo 0 > /sys/module/cifs/parameters/oplock_enabled" -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
