On Fri, Oct 7, 2011 at 10:29 AM, Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> wrote: > On Mon, Oct 3, 2011 at 6:49 AM, Jeff Layton <jlayton@xxxxxxxxx> wrote: >> On Tue, 27 Sep 2011 13:58:49 -0500 >> shirishpargaonkar@xxxxxxxxx wrote: >> >>> From: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> >>> >>> >>> Add mount options backupuid and backugid and their manpage contents. >>> Check for either a valid uid/gid or valid user/group name. >>> >>> >>> Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> >>> --- >>> mount.cifs.8 | 14 +++++++++ >>> mount.cifs.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++- >>> 2 files changed, 97 insertions(+), 2 deletions(-) >>> >>> diff --git a/mount.cifs.8 b/mount.cifs.8 >>> index 81ebdbe..d7eb2dd 100644 >>> --- a/mount.cifs.8 >>> +++ b/mount.cifs.8 >>> @@ -282,6 +282,20 @@ See sections on >>> for more information\&. >>> .RE >>> .PP >>> +backupuid >>> +.RS 4 >>> +Allow access to files with the intent to back them up for a user\&. >>> +.sp >>> +An authenticated user at the server with a privilege can access file system objects with the intent to back them up to which it otherwise may not have access permissions. As an example, a privilege would be "Backup files and directories user right" granted by the server by making that user a part of the built-in group Backup Operators. This mount option restricts to the specified user on the client, as such an authenticated user, privilege to access files with the intent to back them up. >> >> Better, but this is still pretty awkward and confusing. This manpage >> needs to answer 3 things: >> >> 1. what this option does (turn on the backup intent bit in open calls) > > Not sure if implentation specifics need to be mentioned in a man page. > >> >> 2. what the backup intent bit does (allows a user to open files to >> which he wouldn't ordinarily have access) > > So IMHO, this can be phrased as > > 1. what this option does (allows a user to open files to > which he wouldn't ordinarily have access) > >> >> 3. when should (or shouldn't) the user enable it? >> Be specific - list a case, a specific example, when a user couldn't open a file, and where such a mount would help them copy (backup, archive) the file. In particular, if you have files on a server with ACL of [give example] and you have a regular user (even one who is a member of the backup operator group) it would fail, but if the user were a member of the backup operator group and you specify the mount option it would work ... -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html