On 08/20/2011 06:48 AM, Jeff Layton wrote:
> ...as that's more efficient when we know that the lengths are equal.
>
> Reported-by: David Howells <dhowells@xxxxxxxxxx>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
> fs/cifs/cifssmb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index f4d0988..7bac906 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -5849,7 +5849,7 @@ QAllEAsRetry:
>
> if (ea_name) {
> if (ea_name_len == name_len &&
> - strncmp(ea_name, temp_ptr, name_len) == 0) {
> + memcmp(ea_name, temp_ptr, name_len) == 0) {
> temp_ptr += name_len + 1;
> rc = value_len;
> if (buf_size == 0)
Looks good to me.
Reviewed-by: Suresh Jayaraman <sjayaraman@xxxxxxx>
We generally don't query for all EAs very often. Not sure whether how
much it help improve efficiency. But, I do agree that memxxx variants
are better when we know the length.
--
Suresh Jayaraman
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
