Re: [PATCH] cifs: Add mount option named backup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 23, 2011 at 8:15 AM, Jeff Layton <jlayton@xxxxxxxxx> wrote:
> On Mon, 22 Aug 2011 08:33:49 -0500
> Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> wrote:
>
>> On Fri, Aug 12, 2011 at 11:33 AM,  <shirishpargaonkar@xxxxxxxxx> wrote:
>> > From: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx>
>> >
>> >
>> > Add mount option backup.
>> >
>> > It allows an authenticated user to access files with the intent to back them
>> > up including their ACLs, who may not have access permission but has
>> > "Backup files and directories user right" on them (by virtue of being part
>> > of the built-in group Backup Operators.
>> >
>> > If an authenticated user is not part of the built-in group Backup Operators
>> > at the server, access to such files is denied.
>> >
>> >
>> > Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx>
>> > ---
>>
>>
>> Jeff,  Steve,
>>
>> Any comments on this patch (and manpage patch in cifs-utils)?
>>
>
> This seems like a really nasty kludge. It doesn't seem like the
> implications of this have been carefully considered.
>
> What happens I mount with the "backup" flag and do not have the
> necessary permissions on the server to use the flag in an open? Will
> this new flag be mutually exclusive with "multiuser"?

I think this mount option should be mutually exclusive with multiuser.

>
> One idea that might be better is to come up with way to mark certain
> (unix) users with the appropriate flag. If all the backup users were in
> a certan group, for instance, then you could use that info to decide
> whether to set the flag in the open calls.

I think it would be simple and cleanerm for server to enforce the
access privileges since it can.

The intended use of this mount option is only for authenticated
user that are known to have the "Backup files and directories"
user right.

>
> --
> Jeff Layton <jlayton@xxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux