Re: [PATCH] autoconf: fix help message for --enable-cifsidmap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 23 Aug 2011 18:21:06 +0200
"Luk Claes" <Luk.Claes@xxxxxxxx> wrote:

> Hi Jeff
> 
> Hmm, I thought it's auto as default which would only be yes if the  
> needed headers and libraries are installed?
> 
> Cheers
> 
> Luk
> 

Point of semantics I guess :)

I figured the default was "yes", but if the necessary stuff wasn't
present then it would be autodisabled. That's how cifs.upcall works
too. If "default=auto" is more illustrative of this situation then I'll
respin the patch and fix the cifs.upcall help text too.

> Quoting "Jeff Layton" <jlayton@xxxxxxxxx>:
> 
> > It currently says "no" is the default, but it should be "yes".
> >
> > Reported-by: Elias Pipping <pipping@xxxxxxxxxxx>
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxx>
> > ---
> >  configure.ac |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 780abe7..6a9ad75 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -24,7 +24,7 @@ AC_ARG_ENABLE(cifscreds,
> >
> >  AC_ARG_ENABLE(cifsidmap,
> >  	[AC_HELP_STRING([--enable-cifsidmap],
> > -			[Create cifs.idmap binary @<:@default=no@:>@])],
> > +			[Create cifs.idmap binary @<:@default=yes@:>@])],
> >  	enable_cifsidmap=$enableval,
> >  	enable_cifsidmap="maybe")
> >
> > --
> > 1.7.6
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> 
> 
> 
> -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> Luk Claes                                    e-mail: Luk.Claes@xxxxxxxx
> Directie ICT      Afdeling ICT-Infrastructuur            Groep Systemen
> Universiteit Gent      tel: +32 9 264 96 35         fax: +32 9 264 4994
> Krijgslaan 281, gebouw S9, 9000 Gent, Belgie               www.UGent.be
> -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Jeff Layton <jlayton@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux