2011/8/9 J. Bruce Fields <bfields@xxxxxxxxxxxx>: > On Tue, Aug 09, 2011 at 09:11:20PM +0400, Pavel Shilovsky wrote: >> Hi all! >> >> I implemented SMB2.1 leases support for cifs kernel module (in my >> smb2-dev branch - >> http://git.altlinux.org/people/piastry/public/?p=cifs-2.6.git;a=shortlog;h=refs/heads/smb2-dev). >> Now open and create work with leases support - it means that we can >> have several simulаneous opens for the same file and use cache for >> read and write operations (in the case when we use the same superblock >> for these opens). >> >> Whole list of changes since the last status update: >> 1) SMB2 oplocks support (open, breaks). >> 2) SMB2.1 leases support (open, breaks). >> 3) strictcache i/o support for SMB2. >> >> and other minor bugfixes and cleanups. >> >> Your comments are appreciated! > > Just a trivial comment: I think that #ifdef CONFIG_CIFS_SMB2 in > cifs_oplock_beak() is a case where the Linux convention of hiding the > ifdef with a conditionally-defined function would be a lot cleaner.... > > --b. > Thanks for your comment. I rewrote cifs_oplock_break with callbacks and generic function approach - changes are in my tree. -- Best regards, Pavel Shilovsky. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
