2011/8/2 Jeff Layton <jlayton@xxxxxxxxxx>: > On Tue, 2 Aug 2011 06:44:55 -0400 > Jeff Layton <jlayton@xxxxxxxxxx> wrote: > >> On Tue, 2 Aug 2011 02:30:35 +0200 >> Jan Seiffert <kaffeemonster@xxxxxxxxxxxxxx> wrote: >> [snip - bug report] >> >> Thanks for the bug report. Hi Jeff, thanks for your fast feedback, and sorry it took me so long to get back to you. >> According to the spec, I think I was a >> *little* off in the calculation but not by much. CIFSMaxBufSize doesn't >> include the size of the header, so the value we're sending is too small >> by 0x58 bytes. But, if anything though that should have led to the >> server sending smaller frames than we can handle, which should not >> cause this sort of problem. >> >> I tried to reproduce this on my test setup, but couldn't... >> >> Some questions... >> >> 1) did anything pop up in dmesg when this error occurred? >> No, nothing in dmesg. Looks like it is detected as malformed packet and silently dropped. (at dmesg default log level and default debug options) >> 2) are you setting the CIFSMaxBufSize module parm to anything? >> No parameters to the CIFS module (i didn't even know till now there are options...) >> 3) would it be possible to get debugging output? Instructions on how to >> do that are here: >> >> http://wiki.samba.org/index.php/LinuxCIFS_troubleshooting#Enabling_Debugging >> I will skip this ... >> Thanks, > > Nevermind... I was able to reproduce it, and the following patch seems > to fix it for me. Jan, can you test this as well? .. to test your patch, and it looks good! $ ls -l /usr/portage/ | wc -l 170 $ ls -l /usr/portage/distfiles/ | wc -l 47470 So here it is: Tested-by: Jan Seiffert <kaffeemonster@xxxxxxxxxxxxxx> > If so, I'll "officially" send it to Steve and we'll get this in ASAP. > I hope so ;) > Long term, it would be better clean up the way CIFSMaxBufSize is > handled to get rid of this source of confusion... > Sounds good, but with a lot of different servers (orig. Windows versions and different Samba versions), i hope there is no maze of endless special cases because all those versions did something subtle different with the MaxBufSize (eg. simple +/-1 Bugs). Greetings Jan [snip - patch] -- Murphy's Law of Combat Rule #3: "Never forget that your weapon was manufactured by the lowest bidder" -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
