On Fri, 29 Jul 2011 07:14:30 -0400
Jeff Layton <jlayton@xxxxxxxxx> wrote:
> Reported-by: Jan Lieskovsky <jlieskov@xxxxxxxxxx>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxx>
> ---
> mount.cifs.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/mount.cifs.c b/mount.cifs.c
> index 107a5a5..aa4581f 100644
> --- a/mount.cifs.c
> +++ b/mount.cifs.c
> @@ -1419,8 +1419,7 @@ static int check_newline(const char *progname, const char *name)
> static int check_mtab(const char *progname, const char *devname,
> const char *dir)
> {
> - if (check_newline(progname, devname) == -1 ||
> - check_newline(progname, dir) == -1)
> + if (check_newline(progname, devname) || check_newline(progname, dir))
> return EX_USAGE;
> return 0;
> }
Given that this has (minor) security implications, I've gone ahead and
committed this to the repo.
--
Jeff Layton <jlayton@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
