On Sun, 24 Jul 2011 19:00:30 +0400 Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote: > This patchset is going to make demultiplex code smaller and let us intergrate SMB2 protocol support easier further. > > I successfully tested it with Connectathon Testsuites and two parallel mount/umount scripts. > > This is the 4rd version of the patchset that includes minor changes for patch #1. > > > Pavel Shilovsky (5): > CIFS: Move buffer allocation to a separate function > CIFS: Simplify socket reading in demultiplex thread > CIFS: Move RFC1002 check to a separate function > CIFS: Move mid search to a separate function > CIFS: Cleanup demupltiplex thread exiting code > > fs/cifs/connect.c | 653 ++++++++++++++++++++++++++++------------------------- > 1 files changed, 346 insertions(+), 307 deletions(-) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html This patchset seems like a good start. It does have some warts... static int +read_from_socket(struct TCP_Server_Info *server, struct msghdr *smb_msg, + struct kvec *iov, unsigned int to_read, + unsigned int *ptotal_read, bool is_header_read) ...that is_header_read parm could probably be done away with by moving the special handling into the caller. Making these routines more general purpose would be preferable. That said, it's still a good starting point for future cleanup, so I'm inclined to ACK the set. I also ran it through some basic smoke testing and didn't see any problems. Reviewed-and-Tested-by: Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
