On Mon, 11 Jul 2011 10:16:34 -0400 Jeff Layton <jlayton@xxxxxxxxxx> wrote: > ...as that function can sleep. > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > --- > fs/cifs/connect.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index ceab134..dd695c5 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -2241,8 +2241,8 @@ cifs_match_super(struct super_block *sb, void *data) > > rc = compare_mount_options(sb, mnt_data); > out: > - cifs_put_tlink(tlink); > spin_unlock(&cifs_tcp_ses_lock); > + cifs_put_tlink(tlink); > return rc; > } > Steve, this should probably be pushed to 3.0 if possible. This can deadlock if you end up putting the last tcon reference in this call. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
