Re: [PATCH] cifs: make CIFS depend on CRYPTO_ECB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 3 Jun 2011 12:39:41 -0500
Steve French <smfrench@xxxxxxxxx> wrote:

> Merged.  This is a strange dependency - it looks like thee real
> problem is that the two crypto libs we depend on that depend on this
> don't select ECB but it is harmless to add the select.
> 

Hmm...then maybe the patch should this dependency there so that other
kernel subsystems don't get bitten by the same problem?

> On Fri, Jun 3, 2011 at 8:10 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> > On Fri, 03 Jun 2011 14:19:01 +0530
> > Suresh Jayaraman <sjayaraman@xxxxxxx> wrote:
> >
> >> When CONFIG_CRYPTO_ECB is not set, trying to mount a CIFS share with NTLM
> >> security resulted in mount failure with the following error:
> >> Â Â"CIFS VFS: could not allocate des crypto API"
> >>
> >> Seems like a leftover from commit 43988d7.
> >>
> >> Signed-off-by: Suresh Jayaraman <sjayaraman@xxxxxxx>
> >> ---
> >> Âfs/cifs/Kconfig | Â Â1 +
> >> Â1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
> >> index 1cd4c3a..66c68ab 100644
> >> --- a/fs/cifs/Kconfig
> >> +++ b/fs/cifs/Kconfig
> >> @@ -7,6 +7,7 @@ config CIFS
> >> Â Â Â select CRYPTO_MD5
> >> Â Â Â select CRYPTO_HMAC
> >> Â Â Â select CRYPTO_ARC4
> >> + Â Â select CRYPTO_ECB
> >> Â Â Â select CRYPTO_DES
> >> Â Â Â help
> >> Â Â Â Â This is the client VFS module for the Common Internet File System
> >
> > Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
> >
> 
> 
> 


-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux