On Sun, 22 May 2011 07:59:38 -0400 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Sun, May 22, 2011 at 07:55:24AM -0400, Jeff Layton wrote: > > This will never work properly with CIFS, as the protocol has no ability > > whatsoever for looking up files by filehandle. It *might* be possible to > > eventually do this with SMB2, but that remains to be seen. > > > > For now, it just plain doesn't work. Mark it BROKEN to discourage > > distros from enabling it. > > It's actually dead code at this point - fs/nfsd/vfs.c:check_export() > refuses to export a filesystem that does not have a fh_to_dentry > operation, which cifs doesn't provide. > > IMHO it's best to just remove the option and all surrounding code. > I agree and proposed a patch to do that a month or two ago. Steve NAK'ed it for reasons that I don't quite understand. At this point, I'm just trying to make sure distros don't ship with this enabled. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
