Hiya,
Given that I touched this code most recently, I feel morally compelled
to weigh in :)
On Wed, May 11, 2011 at 08:10:08AM -0500, Steve French wrote:
> When we get an access denied on SMB TConX (non existing userid will
> cause sessetup to succeed as guest but SMB tconX to fail) - we now
> unconditionally check for dfs path on any error in SMB TconX which
> results in 9 extra requests. Perhaps we should check for rc == EACCES
> (in cifs_mount in fs/cifs/connect.c)
>
> /* search for existing tcon to this server share */
> tcon = cifs_get_tcon(pSesInfo, volume_info);
> if (IS_ERR(tcon)) {
> rc = PTR_ERR(tcon);
> tcon = NULL;
> goto remote_path_check;
> }
>
> or after remote_path_check label below:
I think in the first place should make sense. I've only seen two
behaviors for remote DFS paths: "not covered" and "no such file or
directory". So checking for EACCESS specifically, and short-circuiting
the remote checks in that case seems pretty reasonable to me, anyway.
sean
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
