Re: [PATCH] cifs: fix some unused variable warnings in id_rb_search

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



merged.

On Wed, May 4, 2011 at 7:08 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> fs/cifs/cifsacl.c: In function ‘id_rb_search’:
> fs/cifs/cifsacl.c:215:19: warning: variable ‘linkto’ set but not used
> [-Wunused-but-set-variable]
> fs/cifs/cifsacl.c:214:18: warning: variable ‘parent’ set but not used
> [-Wunused-but-set-variable]
>
> Cc: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
>  fs/cifs/cifsacl.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c
> index a4aa0f0..bfb5ba5 100644
> --- a/fs/cifs/cifsacl.c
> +++ b/fs/cifs/cifsacl.c
> @@ -211,19 +211,14 @@ id_rb_search(struct rb_root *root, struct cifs_sid *sidptr)
>  {
>        int rc;
>        struct rb_node *node = root->rb_node;
> -       struct rb_node *parent = NULL;
> -       struct rb_node **linkto = &(root->rb_node);
>        struct cifs_sid_id *lsidid;
>
>        while (node) {
>                lsidid = rb_entry(node, struct cifs_sid_id, rbnode);
> -               parent = node;
>                rc = compare_sids(sidptr, &((lsidid)->sid));
>                if (rc > 0) {
> -                       linkto = &(node->rb_left);
>                        node = node->rb_left;
>                } else if (rc < 0) {
> -                       linkto = &(node->rb_right);
>                        node = node->rb_right;
>                } else /* node found */
>                        return lsidid;
> --
> 1.7.4.4
>
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux