Re: [PATCH v4 1/6] cifs: Extract DFS referral expansion logic to separate function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/06/2011 07:56 PM, Sean Finney wrote:
The logic behind the expansion of DFS referrals is now extracted from
cifs_mount into a new static function, expand_dfs_referral.  This will
reduce duplicate code in upcoming commits.

Reviewed-by: Jeff Layton<jlayton@xxxxxxxxxx>
Signed-off-by: Sean Finney<seanius@xxxxxxxxxxx>
---
  fs/cifs/connect.c |  105 +++++++++++++++++++++++++++++++++++------------------
  1 files changed, 69 insertions(+), 36 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 94e60c5..c89d871 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2742,6 +2742,57 @@ build_unc_path_to_root(const struct smb_vol *volume_info,
  	full_path[unc_len + cifs_sb->prepathlen] = 0; /* add trailing null */
  	return full_path;
  }
+
+/*
+ * Perform a dfs referral query for a share and (optionally) prefix
+ *
+ * If a referral is found, mount_data will be set to point at a newly
+ * allocated string containing updated options for the submount.
+ * Otherwise it will be left untouched.
+ *
+ * Returns the rc from get_dfs_path to the caller, which can be used to
+ * determine whether there were referrals.
+ */
+static int
+expand_dfs_referral(int xid, struct cifs_ses *pSesInfo,
				^^^ Did you mean struct cifsSesInfo ?

I'm not seeing any other patch renaming cifsSesInfo to cifs_ses. Or Am I missing something. Sorry about pitching in so late..
			
The compiler gives a warning, but nevertheless it compiles... looks odd.

--
Suresh Jayaraman
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux