On Monday, April 11, 2011 at 21:31, Oskar Liljeblad wrote: > On Monday, April 11, 2011 at 12:59, Shirish Pargaonkar wrote: > > > Modify cifs to assume that the supplied password is encoded according to > > > iocharset. Before this patch passwords would be treated as raw 8-bit data, > > > which made authentication with Unicode passwords impossible (at least > > > passwords with characters > 0xFF). > > > > > > The previous code would as a side effect accept passwords encoded with ISO > > > 8859-1, since Unicode < 0x100 basically is ISO 8859-1. Software which > > > relies on that will no longer support password chars > 0x7F unless it also > > > uses iocharset=iso8859-1. (mount.cifs does not care about the encoding so > > > it will work as expected.) > > > > > > Signed-off-by: Oskar Liljeblad <oskar@xxxxxxxxxxx> > [..] > > With this patch, I am unable to mount a share if user's password happens to > > contain characters like $ e.g. aa$a. > > A Windows client can. > > Hmm, strange, I was not able to reproduce this problem with domain accounts > on Windows 2008 R2. For me $ worked. (That is with locale utf-8 at least.) I'm sorry, please disregard my comment. I tested with the wrong kernel. I will try again. Regards, Oskar -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
