Re: [PATCH 5/5] cifs: clean up various nits in unicode routines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Layton <jlayton@xxxxxxxxxx> wrote:

> On Tue, 5 Apr 2011 12:23:40 -0500
> Steve French <smfrench@xxxxxxxxx> wrote:
> 
> > The patch is fine except that I would prefer that it not introduce a
> > sparse warning
> > (this would be the only endian warning). See below:
> > 
> >   CHECK   fs/cifs/cifs_unicode.c
> > fs/cifs/cifs_unicode.c:309:32: warning: cast from restricted __le16
> >   CC [M]  fs/cifs/cifs_unicode.o
> > 
> 
> Good point. I'll need to put a new variable on the stack to fix it, but
> that's no big deal. I'll fix and resend.

Which line is it that actually gives the warning?  Is it when 0 is implicitly
cast to __le16?  If so, can you just cast it directly?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux