2011/3/28 Suresh Jayaraman <sjayaraman@xxxxxxx>: > On 03/28/2011 02:12 AM, Steve French wrote: >> >> On Sun, Mar 27, 2011 at 2:10 PM, Pavel Shilovsky<piastry@xxxxxxxxxxx> >> wrote: >>> >>> 2011/3/27 Steve French<smfrench@xxxxxxxxx>: >>> As for fsycn logic - as I understand this call - it ought to >>> synchronize data between a cache and storage device. But if we can't >>> free pages, we don't successfully complete this synchronization - so, >>> reporting -EBUSY error here doesn't seem wrong to me (may be we should >>> set -EIO error code - according to the man page). If I am mistaken, >>> please, explain your points. >> >> To me synchronizing means that all data was written to the >> server that was dirty at the time of the call. > > Yes, I too think that fsync should make sure that pages that were dirty > (when fsync started) should be synched to stable storage and need not worry > about the pages that were redirtied after the fsync call. > > > -- > Suresh Jayaraman > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Ok, I will respin this patch. -- Best regards, Pavel Shilovsky. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
