On Sun, 27 Mar 2011 10:18:35 +0200 Oskar Liljeblad <oskar@xxxxxxxxxxx> wrote: > On Sunday, March 27, 2011 at 09:38, Oskar Liljeblad wrote: > > > I noticed that I could not mount cifs shares when the password contained > > > utf8-encoded latin1 characters. [..] > > [..] > > > + len = utf8s_to_ucs2(passwd, 128, (wchar_t *) wpwd); > > > > Looking at the code again, I wonder if not cifs_strtoUCS in cifs_unicode.c > > should've been used instead? > > Here is a tested patch that uses cifs_strtoUCS rather than utf8s_to_ucs2. > > Regards, > > Oskar Looks good overall. I especially like the fact that we're removing those broken unicode conversion routines. You should however resend this patch with a proper description and "Signed-off-by:" line. Also, be sure to run it through scripts/checkpatch.pl and fix anything it complains about. All that said, this is not an area of the code that I know very well. Shirish probably ought to review this... cc'ing him. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
