Re: [CIFS] [PATCH] consistently use smb_buf_length as be32 for cifs (try 3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 17, 2011 at 11:44 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> None of the other fields uses a wrapper, and the name is overly
> confusing.  I'd suggest to just opencode the be32_add_cpu instead of
> wrapping it.

If others feel strongly about this, I don't mind changing it as
Christoph suggests but
- to samba people, "incrementing the rfc1001 length" would be more
recognizable (than opencoding the be32_add_cpu macro), and the
function name was
actually Jeff's suggestion which I liked.
- the other places that refer to this field aren't adding to the length.
- this is the only length field which is big endian (in the protocol)



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux