On Thu, Mar 17, 2011 at 9:29 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: >> - pSMB->hdr.smb_buf_length += count; >> + update_rfc1001_len(pSMB, count); > > The helper is very confusingly named relatively to the field it updates, > moreover we already have nice helpers to do arithmetics on big endian > fields. These can just become: > > be32_add_cpu(&pSMB->hdr.smb_buf_length, count); ok - will change those. -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html