On Sun, Mar 13, 2011 at 3:11 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Sat, Mar 12, 2011 at 11:05:51PM -0600, Steve French wrote: >> In checking new smb2 code for missing endian conversions, I noticed >> some endian errors had crept in over the last few releases into the >> cifs code (symlink, ntlmssp, posix lock, and less problematic warning >> in fscache). Patch follows: > > Is this part of a sparse run or did you check them manually? I run sparse before every checkin, but I had not been running it with checkendian passed in. I don't know a trivial way to check them automatically (as we see e.g. with linux-next automatically warning if new build warning is introduced on some arch). One thing I would love to do is figure out how to automate more of the build verification, unit test process as we do with Samba (for example). -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
