On Sun, 06 Mar 2011 18:11:23 +0100 walter harms <wharms@xxxxxx> wrote: > > > Am 06.03.2011 14:26, schrieb Dan Carpenter: > > This is a cut and paste error. p16 only has 16 chars, not 21. > > > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > > > diff --git a/fs/cifs/smbencrypt.c b/fs/cifs/smbencrypt.c > > index 3967635..1525d5e 100644 > > --- a/fs/cifs/smbencrypt.c > > +++ b/fs/cifs/smbencrypt.c > > @@ -353,7 +353,7 @@ SMBNTencrypt(unsigned char *passwd, unsigned char *c8, unsigned char *p24) > > int rc; > > unsigned char p16[16], p21[21]; > > > > - memset(p16, '\0', 21); > > + memset(p16, '\0', 16); > > memset(p21, '\0', 21); > > > > rc = E_md4hash(passwd, p16); > > > perhaps ARRAY_SIZE() instead of a magic number is a better choice ? > Agreed. Care to propose a patch? There are almost certainly other places in the code that could use a similar cleanup. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
