On Mon, Feb 7, 2011 at 7:54 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote: > Commit 247ec9b4 makes the SMB echo workqueue job skip doing echoes > unless the tcpStatus == CifsGood. Problem: tcpStatus == CifsGood is not > a reliable indicator of whether the socket has had a NEGOTIATE done on > it. This fixes that by adding a new tcpStatus of CifsNeedNegotiate that > indicates this. It also cleans up cifs_reconnect_tcon a bit. > > This is not the only way to fix this issue. As Steve pointed out to me, > we could also check to see whether there's a valid SMB session on the > list as an indicator of whether a NEGOTIATE has been done. I think the > approach I'm proposing clarifies the code better, but I'm willing to go > with his approach if that's the general concensus. Jeff may be right that the code is clearer with this approach (I may try to code the alternative to check) but ... we really shouldn't be sending an SMBecho between negprot and sessionsetup anyway (so checking for sessionsetup may make sense). If a negprot times out or sessionsetup times out we don't need to be sending SMBecho (on the other hand perhaps a really slow krb5 sessionsetup?) Once a sessionsetup is sent, SMBechos make more sense. -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
