On Thu, 3 Feb 2011 21:18:18 -0600 Steve French <smfrench@xxxxxxxxx> wrote: > Good catch. > > But doesn't this belong in stable? > No, it's a recent regression from the call timeout patches. > On Thu, Feb 3, 2011 at 2:31 PM, <shirishpargaonkar@xxxxxxxxx> wrote: > > From: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> > > > > > > Updating extended statistics here can cause slab memory corruption > > if a callback function frees slab memory (mid_entry). > > > > > > Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> > > --- > > fs/cifs/connect.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > > index 945b220..1f32a28 100644 > > --- a/fs/cifs/connect.c > > +++ b/fs/cifs/connect.c > > @@ -633,11 +633,11 @@ incomplete_rcv: > > mid_entry->largeBuf = isLargeBuf; > > multi_t2_fnd: > > mid_entry->midState = MID_RESPONSE_RECEIVED; > > - list_del_init(&mid_entry->qhead); > > - mid_entry->callback(mid_entry); > > #ifdef CONFIG_CIFS_STATS2 > > mid_entry->when_received = jiffies; > > #endif > > + list_del_init(&mid_entry->qhead); > > + mid_entry->callback(mid_entry); > > break; > > } > > mid_entry = NULL; > > -- > > 1.6.0.2 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
