Looking at this comment in the patch:
+ * FIXME: why 48 bytes?
+ */
+ length = checkSMB(smb_buffer, smb_buffer->Mid, total_read);
+ if (length != 0)
cifs_dump_mem("Bad SMB: ", smb_buffer,
total_read < 48 ? total_read : 48);
got me thinking, if you prefer a longer length that is fine. To
avoid huge log entries, while still dumping the most useful info, the
original length dumped was limited. 48 bytes was chosen because it
printed 3 lines of 16 to log and thus would include the most important
parts of the SMB (past wct). It is large enough to fit a close
request and response, although about 10 bytes to small for getting all
of a SMB ReadX request. It would probably be fine to make that 64
bytes if you prefer. If we made it smaller (e.g. 32 instead of 48)
IIRC we wouldn't get wct.
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
