2011/2/3 Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx>:
> On Mon, Jan 31, 2011 at 7:03 AM, Pavel Shilovsky <piastry@xxxxxxxxxxx> wrote:
>> Variable 'i' should be unsigned long as it's used in circle with num_pages,
>> and bytes_read/total_written should be ssize_t according to return value.
>>
>> Signed-off-by: Pavel Shilovsky <piastry@xxxxxxxxxxx>
>> ---
>> fs/cifs/file.c | 11 ++++++-----
>> 1 files changed, 6 insertions(+), 5 deletions(-)
>>
>> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
>> index 74c0a28..e964b1c 100644
>> --- a/fs/cifs/file.c
>> +++ b/fs/cifs/file.c
>> @@ -1662,10 +1662,10 @@ static ssize_t
>> cifs_iovec_write(struct file *file, const struct iovec *iov,
>> unsigned long nr_segs, loff_t *poffset)
>> {
>> - size_t total_written = 0;
>> - unsigned int written = 0;
>> - unsigned long num_pages, npages;
>> - size_t copied, len, cur_len, i;
>> + unsigned int written;
>> + unsigned long num_pages, npages, i;
>> + size_t copied, len, cur_len;
>> + ssize_t total_written = 0;
>> struct kvec *to_send;
>> struct page **pages;
>> struct iov_iter it;
>> @@ -1821,7 +1821,8 @@ cifs_iovec_read(struct file *file, const struct iovec *iov,
>> {
>> int rc;
>> int xid;
>> - unsigned int total_read, bytes_read = 0;
>> + ssize_t total_read;
>> + unsigned int bytes_read = 0;
>> size_t len, cur_len;
>> int iov_offset = 0;
>> struct cifs_sb_info *cifs_sb;
>> --
>> 1.7.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> Should written be initialized to 0 at the top of the outer do loop in
> function cifs_iovec_write() in case CIFSSMBWrite2 returns with
> an error other than EAGAIN without writing anything?
It seems like it assigned to 0 at the start of CIFSSMBWrite2 - so in
this case there is no need to initialize it.
>
> Other than the above query, other things look correct.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Best regards,
Pavel Shilovsky.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
