On Thu, 27 Jan 2011 07:47:56 -0500 Jeff Layton <jlayton@xxxxxxxxxx> wrote: > After receiving a packet, we currently check the header. If it's no > good, then we toss it out and continue the loop, leaving the caller > waiting on that response. This is problematic now that the client waits > indefinitely for responses. > > Check first to see if the packet is big enough for us to read the Mid. > If it's not, then discard it since we can't do anything with it anyway. > > If it is big enough, then go ahead and do the checkSMB checks. Don't > immediately discard the packet however if they fail. Instead, find the > matching mid_q_entry, mark it as having a malformed response and issue > the callback. > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > --- > fs/cifs/cifsglob.h | 2 +- > fs/cifs/connect.c | 24 +++++++++++++++++++++--- > fs/cifs/transport.c | 3 +++ > 3 files changed, 25 insertions(+), 4 deletions(-) > Doh! Self-NAK on this patch. It occurs to me that we need to make sure that checkSMB passes before we allow check2ndT2 to called for the packet. I'll fix and resend the pair of patches -- sorry for the noise... -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
