On Fri, Jan 21, 2011 at 9:42 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote: > On Fri, 21 Jan 2011 09:04:05 -0600 > shirishpargaonkar@xxxxxxxxx wrote: > >> From: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> >> >> Replace remaining use of md5 hash functions local to cifs module >> with kernel crypto APIs. >> Remove header and source file containing those local functions. >> >> >> Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> >> --- >> fs/cifs/Makefile | 2 +- >> fs/cifs/cifsencrypt.c | 1 - >> fs/cifs/link.c | 59 +++++++-- >> fs/cifs/md5.c | 366 ------------------------------------------------- >> fs/cifs/md5.h | 38 ----- >> fs/cifs/smbencrypt.c | 1 - >> 6 files changed, 51 insertions(+), 416 deletions(-) >> delete mode 100644 fs/cifs/md5.c >> delete mode 100644 fs/cifs/md5.h >> > > Very nice. The CIFS parts look good to me, and I'm always fond of > reducing the code we need to support as well as the cifs.ko footprint. > Assuming that mfsymlink support still works after this patch... I did test briefly, e.g. creating symlinks and deleting them. Hoping Stefan Metzmacher will comment. I did verify that the (md5) hash value was different for different actualpaths > > Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx> > -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
