-----Original Message----- From: Shirish Pargaonkar [mailto:shirishpargaonkar@xxxxxxxxx] Sent: Tuesday, January 18, 2011 17:19 To: Ozanski, Grzegorz Cc: smfrench@xxxxxxxxx; linux-cifs@xxxxxxxxxxxxxxx; stable@xxxxxxxxxx Subject: Re: [PATCH] cifs: Fix regression during share-level security mounts On Thu, Jan 6, 2011 at 9:24 AM, <shirishpargaonkar@xxxxxxxxx> wrote: > From: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> > > > NTLM response length was changed during to 16 bytes instead of 24 bytes > that get sent in Tree Connection Request during share-level security > share mounts. Revert it back to 24 bytes. > > > Reported-by: Grzegorz Ozanski <grzegorz.ozanski@xxxxxxxxx> > Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> > --- > fs/cifs/connect.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 41f002f..cdba196 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -2966,7 +2966,7 @@ CIFSTCon(unsigned int xid, struct cifsSesInfo *ses, > bcc_ptr++; /* skip password */ > /* already aligned so no need to do it below */ > } else { > - pSMB->PasswordLength = cpu_to_le16(CIFS_SESS_KEY_SIZE); > + pSMB->PasswordLength = cpu_to_le16(CIFS_AUTH_RESP_SIZE); > /* BB FIXME add code to fail this if NTLMv2 or Kerberos > specified as required (when that support is added to > the vfs in the future) as only NTLM or the much > @@ -2984,7 +2984,7 @@ CIFSTCon(unsigned int xid, struct cifsSesInfo *ses, > #endif /* CIFS_WEAK_PW_HASH */ > SMBNTencrypt(tcon->password, ses->server->cryptkey, bcc_ptr); > > - bcc_ptr += CIFS_SESS_KEY_SIZE; > + bcc_ptr += CIFS_AUTH_RESP_SIZE; > if (ses->capabilities & CAP_UNICODE) { > /* must align unicode strings */ > *bcc_ptr = 0; /* null byte password */ > -- > 1.6.0.2 > > Reported-and-Tested-by: Grzegorz Ozanski <grzegorz.ozanski@xxxxxxxxx> --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. z siedziba w Gdansku ul. Slowackiego 173 80-298 Gdansk Sad Rejonowy Gdansk Polnoc w Gdansku, VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, numer KRS 101882 NIP 957-07-52-316 Kapital zakladowy 200.000 zl This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
