On Wed, 12 Jan 2011 15:42:35 -0600 Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> wrote: > On Wed, Jan 12, 2011 at 2:26 PM, Jeff Layton <jlayton@xxxxxxxxx> wrote: > > The handling of these options is quite convoluted. Change it so that > > these options are stored as numbers and then appended to the option > > strings. > > > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxx> > > --- > > mount.cifs.c | 94 +++++++++++++++++++++++++++++---------------------------- > > 1 files changed, 48 insertions(+), 46 deletions(-) > > > > diff --git a/mount.cifs.c b/mount.cifs.c > > index df92d79..8fccf44 100644 > > --- a/mount.cifs.c > > +++ b/mount.cifs.c > > @@ -857,19 +857,24 @@ parse_options(const char *data, struct parsed_mount_info *parsed_info) > > int rc = 0; > > int got_uid = 0; > > int got_gid = 0; > > - char user[32]; > > - char group[32]; > > + uid_t uid; > > + gid_t gid; > > + char txtbuf[12]; > > Looks correct except perhaps a comment about the value of 12 would be nice. > > Reviewed-by: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> > Good point. I'll add one before I merge it. Thanks, -- Jeff Layton <jlayton@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
