Re: [PATCH] cifs: add mount option to handle stat() failures by 32-bit apps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 11 Jan 2011 05:53:37 -0500
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Tue, Jan 11, 2011 at 04:10:37PM +0530, Suresh Jayaraman wrote:
> > ..compiled without LFS support, but running on 64-bit kernel.
> > 
> > Currently, when a broken (compiled without LFS support) 32-bit application on
> > a 64-bit kernel tries to do a stat(), it fails with -EOVERFLOW error. This
> > problem happens because the 32-bit application is unable to fit the huge
> > 64-bit inode number in its target structure field.
> 
> This is nothing cifs specific.  Please do it in a generic way (e.g.
> sysctl) in the VFS.
> 

I also think a system-wide knob would be preferable. You could get rid
of the module parm for NFS, and change iunique and get_next_ino to
allow 64-bit inode numbers based on its setting.

The only problem I see with a sysctl is that you can change the value
at any time. What happens if you have a bunch of inodes in cache with
large i_ino numbers and then change that setting? Something settable
only at boot time might be better.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux