Re: [PATCH] cifs-utils: fixes for manpage pathname replacement scheme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 14 Dec 2010 12:05:29 -0500
Jeff Layton <jlayton@xxxxxxxxx> wrote:

> Fix up some small problems with pathname replacement:
> 
> 1) replace the bare 'sed' with $(SED)
> 
> 2) '\@' is apparently not portable, so we need to use a different scheme
>    in case we end up using a non-typical sed binary.
> 
> 3) do the sed conversion to a new file and then move it into place. If
>    sed falls down halfway through the conversion we could end up with
>    a half-baked manpage.
> 
> 4) use the $@ construct for brevity and maintainability
> 
> 5) add a comment so that the rationale behind this is explained
> 
> Many thanks to several folks inside Red Hat who pointed out these
> issues.
> 
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxx>
> ---
>  Makefile.am |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 

Patch pushed to master branch.

-- 
Jeff Layton <jlayton@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux