Re: [PATCH 1/4] cifs: remove export_ops code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 17 Dec 2010 20:58:42 +0530
Suresh Jayaraman <sjayaraman@xxxxxxx> wrote:

> On 12/08/2010 08:33 PM, Jeff Layton wrote:
> > Stubs for this code were added under the CONFIG_CIFS_EXPERIMENTAL tag in
> > 2007, but were never completed. The upshot -- anyone who turns on
> > CONFIG_CIFS_EXPERIMENTAL gets a filesystem that pretends to allow exporting
> > via nfsd. Trying to actually use it will just get you an error once
> > nfsd tries to walk into the directory.
> > 
> > Remove this code since it's unfinished. We can reintroduce it once someone
> > spends time on it and makes it usable.
> > 
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> > ---
> >  fs/cifs/Makefile |    2 +-
> >  fs/cifs/cifsfs.c |    7 -----
> >  fs/cifs/cifsfs.h |    4 ---
> >  fs/cifs/export.c |   67 ------------------------------------------------------
> >  4 files changed, 1 insertions(+), 79 deletions(-)
> >  delete mode 100644 fs/cifs/export.c
> 
> Looks good to me.
> 
> Reviewed-by: Suresh Jayaraman <sjayaraman@xxxxxxx>
> 
> Perhaps it would be a good idea to briefly document expected behavior,
> what is working, problems etc (in Samba wiki) so that someone can pick
> up this later?
> 

Sounds reasonable.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux