On Wed, 8 Dec 2010 23:53:12 +0300 Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote: > 2010/12/7 Jeff Layton <jlayton@xxxxxxxxxx>: > > Looks reasonable, though all of this special-casing sure is gross... > > > > Might it be better to have a set of cifs_strict_file/inode_ops and use > > those rather than all of these if/else conditions? > > > > Good idea. So, do you mean to split all these aio_read, aio_write, > fsync and mmap into strict and non-strict calls as we have in direct > i/o case? > Right. Once a mount is declared "strictcache" it won't ever change, so you might as well set the ops appropriately. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
