On Mon, 6 Dec 2010 08:09:56 +0100 Ingo Molnar <mingo@xxxxxxx> wrote: > > * Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote: > > > On Fri, 3 Dec 2010 13:04:40 +1100 Stephen Rothwell wrote: > > > > > Hi all, > > > > > > Changes since 20101202: > > > > > > When CIFS_EXPERIMENTAL is not enabled: > > > > (.text+0xdf6c9): undefined reference to `get_cifs_acl' > > > > from fs/cifs/xattr.c:cifs_getxattr() > > > > > > CONFIG_CIFS=y > > # CONFIG_CIFS_STATS is not set > > CONFIG_CIFS_WEAK_PW_HASH=y > > # CONFIG_CIFS_UPCALL is not set > > CONFIG_CIFS_XATTR=y > > CONFIG_CIFS_POSIX=y > > # CONFIG_CIFS_DEBUG2 is not set > > # CONFIG_CIFS_DFS_UPCALL is not set > > CONFIG_CIFS_FSCACHE=y > > CONFIG_CIFS_ACL=y > > # CONFIG_CIFS_EXPERIMENTAL is not set > > And this build regression has been pushed upstream now, as of: > > 8520eeaa1235: Merge git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6 > > and it is triggering for me too: > > fs/built-in.o: In function `cifs_getxattr': > (.text+0xc518e): undefined reference to `get_cifs_acl' > > The regression got introduced by: > > fbeba8bb16d7: cifs: Handle extended attribute name cifs_acl to generate cifs acl blob (try #4) > > Which introduced the new CIFS_ACL option. > > Thanks, > > Ingo Yeah, looks like this new Kconfig option depends on some code that's under the (much-overloaded) CIFS_EXPERIMENTAL Kconfig option. I think this patch needs some rework. The simple fix would be to make it dependent on CIFS_EXPERIMENTAL, but that's rather icky since CIFS_EXPERIMENTAL pulls in some rather broken stuff... -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
