Re: [PATCH 2/6] CIFS: Make read call work with strict cache mode (try #2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/11/29 Pavel Shilovsky <piastryyy@xxxxxxxxx>:
> 2010/11/29 Christoph Hellwig <hch@xxxxxxxxxxxxx>:
>>
>> Your patch arbitrarily shortens the read to the first vector.  While
>> short reads for regular files are fine with Posix, it will break a lot
>> of userspace applications.
>>
>
> cifs_user_read returns the number of bytes we read from the server and
> it, of course, can be different with requested number. Could you
> explain carefully what do you mean, please? Where is a problem here?
>

It seems to me that I understand what you meant. Of course, it is a
bug to process only one segment while nr_segs can be more than one
here. Thanks!

-- 
Best regards,
Pavel Shilovsky.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux