Re: [PATCH] CIFS: Make cifsFileInfo_put work with strict cache mode (try #3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 28 Nov 2010 11:11:28 +0300
Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote:

> 2010/11/27 Jeff Layton <jlayton@xxxxxxxxxx>:
> > On Thu, 25 Nov 2010 13:51:29 +0300
> > Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote:
> >
> >> 2010/11/21 Pavel Shilovsky <piastryyy@xxxxxxxxx>:
> >> > On strict cache mode when we close the last file handle of the inode we
> >> > should set invalid_mapping flag on this inode to prevent data coherency
> >> > problem when we open it again but it has been modified by other clients.
> >> >
> >>
> >> What's about this patch and other strictcache mode related things?
> >>
> >
> > I'm not sure which ones need review at this point. Perhaps it would be
> > best to re-post the set? If you do, make sure to attach
> > Reviewed-by/Acked-by tags on patches that have already been reviewed.
> >
> 
> Ok, it isn't a problem. Another problem that no one from the series
> got Reviewed-by/Acked-by tags :)
> 
> So, I have several separate set of patches (strict cache,
> ip_connect/port, cifs_open) - let's finised with them in the order,
> because I am a bit confused about it. May be I shouldn't post second
> and third rewritten set until we deal with the first successfully?
> 

Your call. In general, I find that trying to marshal more than one or
two sets of patches at a time is too confusing and labor-intensive.

Other people manage it just fine though, so it's really your
preference.

> In general, I am not think that I understand correctly all the process
> of linux kernel cifs client contributing, can you explain the main
> points or point to a appropriate link, please?
> 

It's not a very formalized process. Basically, contributing to CIFS
means getting patches into Steve's tree and having him push them to
mainline.

I (and others) try to help out by reviewing the patches as they go
across the list. Review is done by volunteers however and our time to
spend on it is limited, so it's generally a good idea to make that job
as painless as you can.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux