On Tue, 9 Nov 2010 08:42:04 -0600
Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx> wrote:
> >> /* Retrieve an ACL from the server */
> >> -static struct cifs_ntsd *get_cifs_acl(struct cifs_sb_info *cifs_sb,
> >> - struct inode *inode, const char *path,
> >> - u32 *pacllen)
> >> +static int
> >> +get_cifs_acl(struct cifs_sb_info *cifs_sb, struct inode *inode,
> >> + const char *path, u32 *pacllen, struct cifs_ntsd **pntsd)
> >> {
> >> - struct cifs_ntsd *pntsd = NULL;
> >> + int rc = 0;
> >> struct cifsFileInfo *open_file = NULL;
> >>
> >> if (inode)
> >> open_file = find_readable_file(CIFS_I(inode), true);
> > ^^^^^^^^^^
> > This predates your patch, but under what conditions would we
> > call this function without an inode? If you're cleaning up the
> > prototype for this function, then I think there are some
> > unneeded arguments here.
> >
>
> Jeff, not sure I understand this comment. But I reposted this patch.
> I will address this issue as soon as I understand it.
I had originally thought that we'd never call get_cifs_acl with a NULL
inode pointer, but it looks like that can happen. I think that this
could stand some overhaul and in that process, we can eliminate some
unneeded arguments, but for now I don't think you can easily do it.
--
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
