On Fri, Nov 5, 2010 at 7:01 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote: On Sun, 10 Oct 2010 15:31:56 -0500 shirishpargaonkar@xxxxxxxxx wrote: > #define MAX_EA_VALUE_SIZE 65535 > #define CIFS_XATTR_DOS_ATTRIB "user.DosAttrib" > +#define CIFS_ACL_XATTR "system.cifsacl" ^^^^^^^^^^ This should probably be defined in terms of CIFS_XATTR_SYSTEM_PREFIX. Ditto for CIFS_XATTR_DOS_ATTRIB, even though that wasn't done by I don't mind either way - there are readability tradeoffs. Also, NFSv4 uses "system.nfs4_acl". It would be nice to follow that convention. Maybe rename this "system.cifs_acl" instead? that makes sense -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html